Skip to content

Update some out-of-date information #1043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 26, 2021
Merged

Update some out-of-date information #1043

merged 5 commits into from
Feb 26, 2021

Conversation

camelid
Copy link
Member

@camelid camelid commented Jan 28, 2021

Fixes #1040. (And some other stuff.)

@camelid camelid added the S-waiting-on-review Status: this PR is waiting for a reviewer to verify its content label Jan 28, 2021
camelid
camelid commented Jan 28, 2021
View reviewed changes
src/traits/chalk.md
into logical inference rules in the [lowering module in rustc](./lowering-module.md).
into logical inference rules in the lowering module in rustc.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this file was removed in #1013.

jyn514
jyn514 reviewed Jan 29, 2021
View reviewed changes
@camelid

This comment has been minimized.

Sign in to view
@jyn514

This comment has been minimized.

Sign in to view
@camelid

This comment has been minimized.

Sign in to view
@jyn514 jyn514 added S-waiting-on-author Status: this PR is waiting for additional action by the OP and removed S-waiting-on-review Status: this PR is waiting for a reviewer to verify its content labels Feb 1, 2021
@jyn514
Copy link
Member

jyn514 commented Feb 9, 2021

ping @camelid - will you have time to look at this soon?

@camelid
Copy link
Member Author

camelid commented Feb 11, 2021

Hopefully, yes.

@JohnTitor JohnTitor mentioned this pull request Feb 20, 2021
Merged
camelid
camelid commented Feb 20, 2021
View reviewed changes
@camelid camelid added S-waiting-on-review Status: this PR is waiting for a reviewer to verify its content and removed S-waiting-on-author Status: this PR is waiting for additional action by the OP labels Feb 21, 2021
jyn514
jyn514 requested changes Feb 21, 2021
View reviewed changes
@spastorino spastorino added S-waiting-on-author Status: this PR is waiting for additional action by the OP and removed S-waiting-on-review Status: this PR is waiting for a reviewer to verify its content labels Feb 26, 2021
@spastorino
Copy link
Member

This looks good, I think after addressing @jyn514 comments is good to go.

@camelid camelid added S-waiting-on-review Status: this PR is waiting for a reviewer to verify its content and removed S-waiting-on-author Status: this PR is waiting for additional action by the OP labels Feb 26, 2021
@jyn514 jyn514 merged commit 1f68820 into rust-lang:master Feb 26, 2021
@camelid camelid deleted the update-info branch February 26, 2021 21:36
@piegamesde

This comment has been minimized.

Sign in to view
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jyn514 jyn514 jyn514 approved these changes

Assignees
No one assigned
Labels
S-waiting-on-review Status: this PR is waiting for a reviewer to verify its content
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Suggestions to use system LLVM link to a section that no longer exists
4 participants
@camelid @jyn514 @spastorino @piegamesde